Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

url_for generates incorrect URLs on Windows

#28

When using url_for function with multiple parameters the returned URL is incorrect on Windows:

 url_for( 'thank_you', '123' ); // => /projects/my_projects\thank_you/123

As you can see, the slash between the base URI and the Limonade URL is a backslash. The problem is in using file_path function to concatenate the URI with limonade path. However, the file_path function is using DIRECTORY_SEPARATOR global variable that is only valid for file paths and not URLs, as it's set to backslash on Windows.

Reported by Martin Cohen · September 11th, 2009 @ 02:52 PM

State: resolved
Assigned to: nobody

Activity

  1. Fabrice Luraine
    Fabrice Luraine
    • Milestone set to Release 0.4 - Fresh Mint And Ginger
    • State changed from new to resolved

    This was fixed in branch 0.4. Will be merged with master soon.

    September 14th, 2009 @ 08:38 AM

  2. Fabrice Luraine
    Fabrice Luraine
    • Milestone order changed from 0 to 0

    (from [0d357db789b48b38c67f0d1e4a07564612304e6b]) In configuration section of the README, describe the proper behaviour about loading libraries. Fixes #28 url_for generates incorrect URLs on Windows. https://github.com/sofadesign/limonade/commit/0d357db789b48b38c67f0...

    May 3rd, 2012 @ 06:52 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.